Skip to content

ci: resolve patched Node instead of stale runner caches #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sybohy merged 2 commits into from
Oct 24, 2026
Merged

ci: resolve patched Node instead of stale runner caches #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed14276
ci: resolve patched Node instead of stale runner caches
sybohy Oct 24, 2026
0cc373e
fix: install patched Node24.22.1 in the development container
sybohy Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG VARIANT="3"

FROM mcr.microsoft.com/vscode/devcontainers/python:${VARIANT}

ARG NODE_VERSION="24"
ARG NODE_VERSION="24.22.1"
ARG UV_VERSION="0.8.17"
ARG UV_SRC="https://astral.sh/uv"

Expand All @@ -15,6 +15,7 @@ ENV NVM_SYMLINK_CURRENT=true \
RUN mkdir /tmp/library-scripts \
&& curl -fsSL -o /tmp/library-scripts/node-debian.sh "${LIBRARY_SCRIPTS_SRC}"
RUN bash /tmp/library-scripts/node-debian.sh "${NVM_DIR}" "${NODE_VERSION}" "${USERNAME}" \
&& test "$(node --version)" = "v24.22.1" \
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* \
&& rm -rf /tmp/library-scripts

Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"build": {
"dockerfile": "Dockerfile",
"args": {
"NODE_VERSION": "24",
"NODE_VERSION": "24.22.1",
"UV_VERSION": "0.8.17",
"VARIANT": "3.14"
}
Expand Down
2 changes: 2 additions & 0 deletions .github/actions/setup-node/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ runs:
if: inputs.install_dependencies == 'true'
with:
node-version: ${{ inputs.node_version }}
check-latest: true
registry-url: ${{ inputs.registry_url }}
- name: Setup Node.js without cache
uses: actions/setup-node@v7
if: inputs.install_dependencies == 'false'
with:
node-version: ${{ inputs.node_version }}
check-latest: true
registry-url: ${{ inputs.registry_url }}
- name: Install dependencies
if: inputs.install_dependencies == 'true'
Expand Down
Loading