MQTT: do not crash when MQTTPublish has no underlayer - #5089
Open
DSeaStar wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5089 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 390 390
Lines 96800 96800
=======================================
+ Hits 78006 78008 +2
+ Misses 18794 18792 -2
🚀 New features to boost your workflow:
|
Member
|
Could you disclose what tool you used to generate this PR in the commit tag? Thanks |
Author
|
Sure — the implementation and commit message were drafted with AI assistance (Claude), then reviewed and adjusted by me. I've amended the commit trailer to |
Member
|
Okay thanks for the explanation. Your github profile is very sus, so I hope you don't mind me asking |
MQTTPublish.msgid and MQTTPublish.value read QOS/len from the underlayer without a None check, so MQTTPublish().show() raised AttributeError. Guard both callbacks so a standalone publish packet can be displayed. Fixes secdev#5071 AI-Assisted: yes (Claude) Signed-off-by: SeaStar Deng <172368758@qq.com>
DSeaStar
force-pushed
the
fix/mqtt-publish-no-underlayer
branch
from
August 15, 2026 10:14
79525ee to
2da8509
Compare
Author
|
Done — the commit trailer now reads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5071.
MQTTPublishreadsQOSandlenfrompkt.underlayerin themsgidcondition and thevaluelength callback. Building or displaying a publish packet with no underlayer (MQTTPublish().show()) raisedAttributeError: 'NoneType' object has no attribute 'QOS'.Both callbacks now treat a missing underlayer as QoS 0 / empty payload, which matches how a standalone publish is constructed. Existing layered build/dissect tests are unchanged.
Repro that used to crash:
./test/run_tests -P "load_contrib('mqtt')" -t test/contrib/mqtt.uts— 25 passed.