Repository navigation
Conversation
While linked through the Relay, signed in and recognizing through the voice service, the daemon fetches a voice token for a box that says VOICE DIRECT and sends it as voice.token: at once, again whenever the box says it again (a new link or reboot), and every 45 minutes. Firmware that doesn't say VOICE DIRECT is never sent one, so today's boxes don't answer it with an unknown-voice-event error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162. Stacked on #169 (voice v1 with the session), which is stacked on #168. Each retargets to main as the one below it merges. The token endpoint is vibebuddy-cloud#15 (on staging); its wire format is in #171.
What changes
VOICE DIRECT, and the computer must be signed in and recognizing through the voice service. The daemon then fetchesPOST /v1/voice/tokenfor the box's key and sends it as{"event":"voice.token","token","expires_at"}.VOICE DIRECTagain (a new link or a reboot, since the box keeps the token only in RAM), and every 45 minutes for a token that lasts an hour.VOICE DIRECTis new. It's the firmware's way of saying it can call the service itself; the firmware side is Accounts: voice over the Relay through the link #163. Today's firmware answers any unknownvoice.*event withvoice.error"unknown voice event", so without this line no box is sent a token.Recognizer::is_voice_service). The box can't hold their key, so its audio keeps coming over the link (ADR-0018).VOICE DIRECTamong the hello replies. How the box hands over the transcript and plays replies on that path is left to Accounts: voice over the Relay through the link #163.Checked
cargo test --workspace --locked: all pass. The daemon has 340.Account::voice_tokenagainst a fake service: the request, the session, and a 401 signing out;vbt1.t0, thenvbt1.t1right after it saysVOICE DIRECTagain.VOICE DIRECT, the restart test fails.cargo clippy --workspace --all-targets --locked: no new warnings.VOICE DIRECTyet (Accounts: voice over the Relay through the link #163).🤖 Generated with Claude Code