Bring in an updated Dullahan autobuild package containing an updated version of CEF 146#5584
Open
callumlinden wants to merge 27 commits into
Open
Bring in an updated Dullahan autobuild package containing an updated version of CEF 146#5584callumlinden wants to merge 27 commits into
callumlinden wants to merge 27 commits into
Conversation
…rsion of CEF v146. No changes to Dullahan or Viewer C++ code
Collaborator
|
Should be fine - though we might want to ask QA to run whatever regression tests they have available for this. |
…5632) The glTF importer branches on LLJointData::mSupport when it decides whether a collision volume should inherit the current rest matrix or the support-rest matrix. That value was never copied from the avatar skeleton XML into LLJointData, so the importer was effectively making that decision on uninitialized state.
The glTF importer rebuilt collision volume override-rest matrices from the imported translation override and viewer-side scale only. That dropped the collision volume rotation defined in avatar_skeleton.xml and produced incorrect inverse bind matrices for rotated collision volumes, especially the torso volumes that use non-uniform scale. The result was a visible mismatch between rigged mesh imported from .glb and the equivalent .dae upload.
…lay the type of connection the version is applicable to.
Bumps [BugSplat-Git/symbol-upload](https://github.com/bugsplat-git/symbol-upload) from 095d163ae9ceb006d286a731dcd35cf6a1b458c8 to 2a0d2b8cf9c54c494144048f25da863d93a02ccd. - [Release notes](https://github.com/bugsplat-git/symbol-upload/releases) - [Commits](BugSplat-Git/symbol-upload@095d163...2a0d2b8) --- updated-dependencies: - dependency-name: BugSplat-Git/symbol-upload dependency-version: 2a0d2b8cf9c54c494144048f25da863d93a02ccd dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ated version of CEF v146 (146.0.10). No changes to Dullahan or Viewer C++ code
Contributor
Author
|
Pulled in the latest CEF (146.0.10) via the usual CEF -> Dullahan -> Viewer Confirmed that it appears to work as expected (simple smoke test with > 1 instances) and that the version is correct ( |
#5634: Apply version string from janus server if available. Also display the type of connection the version is applicable to.
… BP face after PBR face
This reverts commit 53af39b.
This fixes a bug where the user logs in with good cache, server issues use-cached response, and then the viewer would send another mutelist request on region change. Signed-off-by: Darl <me@darl.cat>
Constitutes zero behavioral changes. Signed-off-by: Darl <me@darl.cat>
Velopack's uninstall can't be canceled, so instead it now checks for presense of a running window, makes sure window matches velopack's path, then sends a shutdown message. Window gets the message, verifies path, initiates shutdown.
…ated version of CEF v146 (146.0.12) for Windows/macOS. No changes to Dullahan or Viewer C++ code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in a new version of the Dullahan autobuild package that was built was against CEF version 146.
This updated PR pulls in CEF 146.0.12 (vs versions in earlier inrevisions of this PR 146.0.7 and 146.0.10). Other than the requisite CEF -> Dullahan -> Viewer autobuild steps, no other code was modified.
This change is for Windows and macOS only. Linux version to follow when we are able to create a compatible v146 version of CEF and remains on version 139.
No changes were required in Dullahan or Viewer C++ code - merely updated in Dullahan autobuild.xml to point to the new C++ binaries and in the Viewer autobuild.xml to point to the updated Dullahan.
For QA/testing, it's been 8 months since the version of CEF used in the canonical Viewer (v139) was released so there will be a very large number of changes in CEF itself.
I did a simple smoke test and confirmed that web pages appear to render as before, links work, keyboard works etc. but if there are issues to resolve, it will be in the more esoteric areas of integration - SLURL support, multiple windows, cookie management etc. I don't know if this warrants a full browser integration regression test - perhaps we wait for feedback in the alpha phase before making that call.