#4320 Bugsplat fails to catch thread crashes on Apple Silicon#5866
Draft
akleshchev wants to merge 1 commit into
Draft
#4320 Bugsplat fails to catch thread crashes on Apple Silicon#5866akleshchev wants to merge 1 commit into
akleshchev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to improve BugSplat crash capture on Apple Silicon by adjusting Unix signal configuration: resetting process-wide handlers to defaults when building with BugSplat, and unblocking key crash signals in newly started threads.
Changes:
- For
LL_BUGSPLATnon-Windows builds, callclear_signals()duringLLApp::setupErrorHandling()to restore default signal handlers. - In
LLThread::threadRun()(non-Windows), explicitly unblock several synchronous “crash” signals viapthread_sigmask(). - Minor comment updates around signal handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
indra/llcommon/llthread.cpp |
Unblocks crash-related signals in newly started threads on non-Windows platforms. |
indra/llcommon/llapp.cpp |
Changes non-Windows BugSplat builds to reset signal handlers to defaults during error-handling setup; updates related comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_4320_2
branch
from
1a01a3d to
23d92e6
Compare
akleshchev
force-pushed
the
andreyk/viewer_4320_2
branch
from
23d92e6 to
5b8c497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugsplat fails to catch thread crashes on Apple Silicon, want to see if explicitly setting up signal handling helps.
Just throwing things at a wall to see what sticks.