feat(tests): add step timing tracking to E2E tests

[abueide]

Summary

Adds timing instrumentation to the E2E test framework so we can see exactly how long each step takes in CI logs.

Problem

Currently, E2E tests show pass/fail but no timing information. When a test takes 37 minutes (React Native iOS), we don't know where the time is being spent without manual analysis of logs.

Solution

Test Framework Changes

New Functions:

• e2e_step_start(step_name) - Records start timestamp
• e2e_step_end(step_name, status, [reason]) - Records end timestamp, calculates duration

Enhanced Reporting:

• e2e_report_steps() now displays duration for each step:

  ✓ PASS: build-node (23s)
  ✓ PASS: install-pods (45s)
  ✓ PASS: build-ios (312s)
  ✓ PASS: deploy (8s)
  ✗ FAIL: verify-app (14s)
    Reason: App crashed during soak period
  

Removed Functions:

• e2e_step_pass() / e2e_step_fail() - Replaced by start/end pattern for timing

React Native iOS E2E Instrumented Steps

Updated 5 critical steps in test-suite-ios-e2e.yaml:

• ✅ build-node - npm install timing
• ✅ install-pods - CocoaPods install timing
• ✅ build-ios - xcodebuild timing (longest step)
• ✅ deploy - App deployment timing
• ✅ verify-app - Liveness check + soak period timing

Usage Pattern

processes:
  my-step:
    command: |
      set -e
      _step="my-step"
      
      # Source test framework
      export REPO_ROOT="$(cd ../.. && pwd)"
      . "$REPO_ROOT/plugins/tests/test-framework.sh"
      
      # Record start time
      e2e_step_start "$_step"
      
      # Trap errors for timing
      trap 'e2e_step_end "$_step" "fail" "Error: $?"' ERR
      
      # ... do work ...
      
      # Record success with timing
      e2e_step_end "$_step" "pass"

Benefits

1. 🔍 Better observability - Immediately see where time is spent
2. ⚡ Identify bottlenecks - Spot slow steps at a glance
3. 📊 Performance tracking - Baseline for future optimizations
4. 🐛 Better debugging - Know which step failed AND how long it ran
5. 📈 Regression detection - Can detect when steps get slower over time

Example CI Output

Before:

✓ PASS: build-node
✓ PASS: install-pods
✓ PASS: build-ios
✓ PASS: deploy
✓ PASS: verify-app

After:

✓ PASS: build-node (23s)
✓ PASS: install-pods (45s)
✓ PASS: build-ios (312s)    ← 😱 This is the bottleneck!
✓ PASS: deploy (8s)
✓ PASS: verify-app (14s)

Next Steps

• Add timing to Android E2E tests
• Add timing to standalone iOS/Android tests
• Add timing to other React Native test suites
• Consider adding total time summary at end

Testing

Will validate in CI when this PR runs. Timing should appear in test output logs.

---

🤖 Generated with Claude Code