Repository navigation
feat(tracing): show browser console errors in the trace file - #203
Merged
Merged
Conversation
Console errors were already collected per test but never rendered in the trace. Add a Console Errors section (HTML-escaped), omitted when empty. Refs #130 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Refs #130 (console entries in the trace).
browser.captureConsoleErrorsalready collects JS errors per test, but the trace file never showed them. A shared trace should include what the browser logged, so this adds a Console Errors section (HTML-escaped, omitted when empty).Scope
Console errors only, at test level. Per-step console/network entries, locators per step and DOM snapshots are not in this PR.
Verification
buildHtml_rendersConsoleErrors_escapedfailed before the change and passes after; a second test checks the section is omitted when there are none.mvn test: 827 passed, 0 failures.🤖 Generated with Claude Code