Repository navigation
feat(tracing): list the locators each step used in the trace - #204
Merged
Merged
Conversation
Terminal Locator actions record the locator and offset into the test's timing; the trace groups them under the step they ran in and marks lookups that timed out. Refs #130 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> # Conflicts: # src/main/java/com/seleniumboot/tracing/TraceRecorder.java # src/test/java/com/seleniumboot/unit/TraceRecorderTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Refs #130 (locators used per step).
A shared trace shows what happened but not which element each action targeted. Terminal
Locatoractions (everything throughwhenReady) now record the locator and time offset; the trace lists them under Locators Used, grouped beneath the step they ran in (earlier ones under "Before first step"). A lookup that timed out is marked not found. No config, capped at 1000 per test.Scope
Only actions that go through
Locator's wait path. Rawdriver.findElementcalls and non-waiting probes (count(),isVisible()) are not recorded. The action name (click vs type) is not recorded, only the locator.Verification
Locator.click()records intoTestTiming.mvn test: 829 passed, 0 failures.🤖 Generated with Claude Code