Skip to content

Added some functions for working with graph inverse semigroups and their congruences - #1204

Open
joe-dw wants to merge 45 commits into
semigroups:mainfrom
joe-dw:main
Open

Added some functions for working with graph inverse semigroups and their congruences#1204
joe-dw wants to merge 45 commits into
semigroups:mainfrom
joe-dw:main

Conversation

@joe-dw

@joe-dw joe-dw commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Functions have been added to find edges and paths with range or source of a given vertex in a graph inverse semigroup, as well as finding the positive and negative paths that form any given element. There is also a new definition for the trace of a congruence by Wang pair, and graph inverse semigroup specific implementations of CongruenceTestMembershipNC, ImagesElm and EquivalenceRelationPartition for both traces and congruences.

@joe-dw
joe-dw marked this pull request as ready for review July 29, 2026 10:50
@james-d-mitchell james-d-mitchell mentioned this pull request Aug 20, 2026

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some more polishing and some more justification for the changes that you want to introduce. Please update and try again.

Comment thread doc/congsemigraph.xml Outdated
Comment thread doc/semigraph.xml Outdated
Comment thread doc/semigraph.xml Outdated
Comment thread doc/semigraph.xml
Comment thread doc/semigraph.xml Outdated
Comment thread gap/congruences/congsemigraph.gi Outdated
Comment thread gap/congruences/congsemigraph.gi Outdated
Comment thread gap/congruences/congsemigraph.gi Outdated
Comment thread gap/congruences/congsemigraph.gi Outdated
Comment thread gap/congruences/congsemigraph.gi Outdated
@james-d-mitchell james-d-mitchell added new-feature A label for PRs that contain new features waiting-for-creator-input A label for issues or PR that are waiting for input from their creator labels Aug 24, 2026
joe-dw and others added 7 commits August 31, 2026 11:18
@joe-dw joe-dw reopened this Aug 31, 2026
@joe-dw

joe-dw commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

@james-d-mitchell I just have the errors with the docs where GAP's new line symbol doesn't match up with the char ~ and couldn't figure out how to fix that. Is there a way for GAP to overwrite the examples in an xml?

@james-d-mitchell

Copy link
Copy Markdown
Collaborator

@james-d-mitchell I just have the errors with the docs where GAP's new line symbol doesn't match up with the char ~ and couldn't figure out how to fix that. Is there a way for GAP to overwrite the examples in an xml?

Sadly there is not, the ~ in the output is generated by the Semigroups package to indicate that there is a space at the end of the line, so if you add spaces everywhere you see a ~ in the expected output you should be okay.

joe-dw and others added 2 commits August 31, 2026 12:47
@joe-dw

joe-dw commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

@james-d-mitchell looks like all tests are passing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature A label for PRs that contain new features waiting-for-creator-input A label for issues or PR that are waiting for input from their creator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants