[UIK-4448][stories] remove hardcoded values#2936
Open
j-mnizhek wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
accordion
add-filter
badge
base-components
bulk-textarea
button
card
color-picker
counter
data-table
date-picker
drag-and-drop
dropdown-menu
fullscreen-modal
illustration
input-mask
input-tags
mini-chart
modal
notice-bubble
notice
product-head
progress-bar
select
side-panel
d3-chart
tooltip
widget-empty
labels
ilyabrower
force-pushed
the
UIK-4448/fix-hardcoded-values
branch
from
4d2da5e to
a152106
Compare
Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/flex-box
Added
color,bg,border,borderRadius.@semcore/theme
Changed
Motivation and Context
Replaced hardcoded values (colors, margins, paddings, border-radii) to the corresponding variables:
How has this been tested?
Manually with Storybook.
Types of changes