[UIK-5245][Documentation] Update illustrations#2968
Open
j-mnizhek wants to merge 17 commits into
Open
Conversation
6 tasks
| @@ -90,8 +90,9 @@ | |||
| "node-watch": "0.7.3", | |||
| "picocolors": "1.0.0", | |||
| "postcss": "8.4.33", | |||
| "sharp": "0.34.5", | |||
Contributor
There was a problem hiding this comment.
@ilyabrower I moved sharp to dev deps and updated it to newer version, also added figma rest-api-spec - it's just types
Contributor
There was a problem hiding this comment.
also I broke the lock file :'(
Contributor
|
@ilyabrower added you because I changed deps in /website |
Contributor
|
Updated the figma illustrations script to work faster and to apply scaling only to big pics. |
…and than set the correct value (#2933) ## Changelog ### @semcore/ellipsis #### Fixed - Values with asynchronous initialization are not displayed in text with ellipses. <!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? I've added a test <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [X] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
## Changelog ### @semcore/theme #### Fixed - Radii variables. <!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [X] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
…2958) Just a small fix in the documentation: - Added common recommendations to the validation page - Fixed and refferenced these recommendations in the Content in Modal, Form and Notice guides - Updated illustrations - Removed outdated info from the Validation page (consulted with UX writers) <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve.
ilyabrower
reviewed
Jun 1, 2026
| await getIllustration(children, category, fileId); | ||
| }), | ||
| .forEach(async (page) => | ||
| await getIllustration(page, category, fileId), |
Contributor
There was a problem hiding this comment.
this won't work as you expexted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update to align the new styles:
Fixed:
ReferenceLine.Backgroundplacement in the example to match expected outputNote for Lera: update screenshot tests for it
How has this been tested?
Manually.
Types of changes