[#17] Mention serokell_danger as an optional CI check - #18
Draft
heitor-lassarote wants to merge 1 commit into
Draft
[#17] Mention serokell_danger as an optional CI check#18heitor-lassarote wants to merge 1 commit into
heitor-lassarote wants to merge 1 commit into
Conversation
Problem: The setup-ci skill's "Common checks (apply everywhere)" section lists reuse lint, no-trailing-whitespace, xrefcheck, and shellcheck, but says nothing about serokell_danger, even though it overlaps with some of those same checks. An agent following setup-ci/bootstrap-repo has no way to discover this gem exists. Solution: Add an "Optional: Danger checks for PR/MR review" section pointing to serokell/danger's README and metatemplates' docs/danger.md for the Gemfile/Dangerfile snippet and CI wiring. Kept out of the mandatory "Common checks" list since it needs a Ruby/Bundler toolchain, unlike the language-agnostic checks already there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
setup-ciskill's "Common checks (apply everywhere)" sectionlisted
reuse lint, no-trailing-whitespace,xrefcheck, andshellcheck, but said nothing about theserokell_dangergem, eventhough it overlaps with some of those same checks. An agent following
setup-ci/bootstrap-repohad no way to discover the gem exists.Added an "Optional: Danger checks for PR/MR review" section pointing
to
serokell/danger's README and tometatemplates'docs/danger.mdfor the
Gemfile/Dangerfilesnippet and CI wiring. Kept it out ofthe mandatory "Common checks" list, since it needs a Ruby/Bundler
toolchain unlike the language-agnostic checks already there.
Depends on serokell/metatemplates#31:
the
docs/danger.mdlink only resolves once that PR merges, soxrefcheckis expected to fail here until then. Opened as a draft forthat reason; will mark ready once #31 lands.
Related issue(s)
Fixed #17
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Agent instructions (conditional)
it followed the agent instructions in
plugins/serokell-global/skills/and
.github/copilot-instructions.md.Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)