Skip to content

Prefix release tags with v for Go module compatibility - #5

Merged
jvmvik merged 1 commit into
masterfrom
prefix-release-tags-with-v
Aug 16, 2026
Merged

Prefix release tags with v for Go module compatibility#5
jvmvik merged 1 commit into
masterfrom
prefix-release-tags-with-v

Conversation

@jvmvik

@jvmvik jvmvik commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #3 (tagging convention half — see caveat below).

Problem

The release target tagged ${version} verbatim, producing tags like 1.1.0. Go modules require the v prefix to resolve a tag as a semantic version, so consumers fell back to pseudo-versions:

require github.com/serpapi/serpapi-golang v0.0.0-20260126142127-0e41c7993cda

Change

Prefix the tag with v at the tagging site only:

release: oobt version
	git tag -a v${version}
	git push origin v${version}

VERSION in serpapi.go deliberately stays bare — it is sent as the source=go:1.1.0 API parameter, so the prefix belongs on the git tag rather than in the constant.

Verified with make -n release, which now expands to git tag -a v1.1.0.

Caveat — this alone does not close the issue

The issue also asks for v-prefixed tags on the existing release commits. Those have to be pushed by hand and are not part of this diff:

git tag -a v1.0.0 44cda64 -m "Official SerpApi client wrapper (new API version 1.0.0)"
git tag -a v1.1.0 0e41c79 -m "release version 1.1.0"
git push origin v1.0.0 v1.1.0

Note that v1.1.0 above points at master's tip rather than at the commit the existing 1.1.0 tag references — that tag points to an off-master commit predating the remove-num-param merge.

🤖 Generated with Claude Code

The release target tagged ${version} verbatim (e.g. 1.1.0), which the Go
module resolver does not accept as a semantic version, so consumers fell
back to pseudo-versions. Prefix the tag with v at the tagging site only;
VERSION in serpapi.go stays bare since it is sent as the source=go:X.Y.Z
API parameter.

Refs #3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jvmvik
jvmvik merged commit 8213545 into master Aug 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add v prefix to release tags for Go module compatibility

1 participant