Prefix release tags with v for Go module compatibility - #5
Merged
Conversation
The release target tagged ${version} verbatim (e.g. 1.1.0), which the Go
module resolver does not accept as a semantic version, so consumers fell
back to pseudo-versions. Prefix the tag with v at the tagging site only;
VERSION in serpapi.go stays bare since it is sent as the source=go:X.Y.Z
API parameter.
Refs #3
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3 (tagging convention half — see caveat below).
Problem
The
releasetarget tagged${version}verbatim, producing tags like1.1.0. Go modules require thevprefix to resolve a tag as a semantic version, so consumers fell back to pseudo-versions:Change
Prefix the tag with
vat the tagging site only:VERSIONinserpapi.godeliberately stays bare — it is sent as thesource=go:1.1.0API parameter, so the prefix belongs on the git tag rather than in the constant.Verified with
make -n release, which now expands togit tag -a v1.1.0.Caveat — this alone does not close the issue
The issue also asks for
v-prefixed tags on the existing release commits. Those have to be pushed by hand and are not part of this diff:Note that
v1.1.0above points at master's tip rather than at the commit the existing1.1.0tag references — that tag points to an off-master commit predating theremove-num-parammerge.🤖 Generated with Claude Code