Repository navigation
Preserve header order with per-request emulation - #6
Open
Joseph-Mutua wants to merge 1 commit into
Open
Joseph-Mutua wants to merge 1 commit into
Joseph-Mutua wants to merge 1 commit into
Conversation
Author
|
Evidence for the issue reproduction and verification: |
Author
Joseph-Mutua
force-pushed
the
fix/preserve-header-order-request-options
branch
from
September 17, 2026 17:41
f323835 to
b51f498
Compare
Author
|
Hi @zyc9012 @moya1295, I’ve rebased this onto the current main branch and resolved the changes introduced since the PR was opened. I also narrowed the regression test so it only checks the reported header-ordering behavior. Local verification passes:
GitHub Actions is currently waiting for maintainer approval. When you have a chance, could you approve the workflows and review the updated diff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was happening
Per-request emulation replaces the request's original-header ordering, so a custom order configured on the client was lost. The wrapper now retains the explicit client order and merges it ahead of the selected request emulation's order.
Testing
bundle exec rake compilebundle exec ruby -Itest test/client_test.rbbundle exec rake testtls.peet.wsand verified all five casesFixes #1