Repository navigation
Conversation
The platform gems declare >= 2.7, < 3.5.dev, but only 2.7, 3.3 and 3.4 were built, so require fails on 3.0-3.2 after the platform gem installs.
The x86_64 cross image's objcopy exits cleanly without rewriting aarch64 archives, so the extension referenced prefixed symbols that were never defined.
Author
|
The Release workflow passes with these changes on my fork, same commit (b68862c): https://github.com/yask123/wreq-rb/actions/runs/36496828045 All four cross-compiles succeed, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps in the precompiled gems. Both install fine and then fail at
require:btls-sysprefixes BoringSSL symbols with a bareobjcopy --redefine-syms, and the x86_64 cross image'sobjcopyexits 0 without rewriting aarch64 archives. The extension then references prefixed symbols that were never defined (104 in 0.6.2's3.4/wreq_rb.so), so on arm64 you getundefined symbol: build_script_main_SSL_CTX_set_grease_enabled. The pre-script now puts the image'saarch64-linux-gnu-objcopy/-nmfirst onPATHfor that target,cache-versionis bumped so the stale BoringSSL build isn't restored, andtest-cross-gemalso installs the aarch64 gem on anubuntu-24.04-armrunner.>= 2.7, < 3.5.devbut only 2.7, 3.3 and 3.4 are built, so 3.0–3.2 fail withcannot load such file -- .../lib/wreq_rb/wreq_rb. rake-compiler-dock 1.10 already has those cross rubies, and 1.11 still has 3.0.7, so this composes with Add Ruby 4.0 to precompiled gem matrix; drop Ruby 2.7 #2.Tested locally with rb-sys-dock 0.9.123 and the new pre-script: the aarch64-linux gem (3.0 + 3.4) passes the test suite on Ruby 3.0 / Ubuntu 22.04 arm64 (58 runs, 0 failures) and loads on Ruby 3.4. actionlint is clean.
The root cause is probably better fixed in btls-sys by using the target's
objcopy/nmwhen cross-compiling. Happy to open an issue there. Side note: therescue LoadErrorfallback inlib/wreq-rb.rbreplaces the real undefined-symbol error withcannot load such file, which is why this was hard to spot.