feat: Merge the tab bar underline into surrounding box borders - #32
Merged
Conversation
FXschwartz
marked this pull request as ready for review
August 12, 2026 20:16
marcelomendoncasoares
approved these changes
Aug 13, 2026
marcelomendoncasoares
left a comment
marcelomendoncasoares
left a comment
Collaborator
There was a problem hiding this comment.
Only one minor nit on the test, but already leaving approved! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With nocterm 0.9.0's box-line blending, the tab bar's heavy underline (━) still stopped short of the borders around it, leaving gaps at both ends and at the pane divider in serverpod start's side-by-side layout.
This paints a full-width bold base rule behind the tab segments with negative indents, so its ends land on the surrounding box border cells and merge into junctions (┝/┥). The per-segment underline rendering (active-tab highlight, ╸/╺ gaps) is unchanged, segments overwrite every in content cell, so the base only shows where it reaches the border. With no surrounding border, the reached ends paint nothing.
Note: One thing I did have to change is now that the borders are actually merging it did not look good to have the app bar border a different color than the borders it is merging with because those merged characters will either be the outside border color or the app bar color.
Before
After