Remove the pop_except_from! macro#742
Open
mrobinson wants to merge 1 commit into
Open
Conversation
This the first step toward a more generic SIMD optimized path for scanning ahead and also for a potentially easier way of bailing out of this loop using the `?` Rust operator. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
simonwuelker
approved these changes
May 18, 2026
Member
simonwuelker
left a comment
simonwuelker
left a comment
There was a problem hiding this comment.
and also for a potentially easier way of bailing out of
this loop using the ? Rust operator.
The unstable Try trait would be very helpful here: rust-lang/rust#84277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This the first step toward a more generic SIMD optimized path for
scanning ahead and also for a potentially easier way of bailing out of
this loop using the
?Rust operator.