Skip to content

fix(python): use non-deprecated params in search benchmark fixtures #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sezruby wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

fix(python): use non-deprecated params in search benchmark fixtures #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions python/python/benchmarks/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ def create_base_dataset(data_dir: Path) -> lance.LanceDataset:
rows_remaining -= next_batch_length
table = create_table(next_batch_length, offset)
if offset == 0:
dataset = lance.write_dataset(table, tmp_path, use_legacy_format=False)
dataset = lance.write_dataset(
table, tmp_path, data_storage_version="stable"
)
else:
dataset = lance.write_dataset(
table, tmp_path, mode="append", use_legacy_format=False
table, tmp_path, mode="append", data_storage_version="stable"
)
offset += next_batch_length

Expand All @@ -98,7 +100,7 @@ def create_base_dataset(data_dir: Path) -> lance.LanceDataset:
dataset.create_scalar_index("category", "BITMAP")
dataset.create_scalar_index("genres", "LABEL_LIST")

return lance.dataset(tmp_path, index_cache_size=64 * 1024)
return lance.dataset(tmp_path, index_cache_size_bytes=512 * 1024 * 1024)


def create_delete_dataset(data_dir):
Expand All @@ -113,7 +115,7 @@ def create_delete_dataset(data_dir):
dataset = lance.dataset(tmp_path)
dataset.delete("filterable % 2 != 0")

return lance.dataset(tmp_path, index_cache_size=64 * 1024)
return lance.dataset(tmp_path, index_cache_size_bytes=512 * 1024 * 1024)


def create_new_rows_dataset(data_dir):
Expand All @@ -129,7 +131,7 @@ def create_new_rows_dataset(data_dir):
table = create_table(NEW_ROWS, offset=NUM_ROWS)
dataset = lance.write_dataset(table, tmp_path, mode="append")

return lance.dataset(tmp_path, index_cache_size=64 * 1024)
return lance.dataset(tmp_path, index_cache_size_bytes=512 * 1024 * 1024)


class Datasets(NamedTuple):
Expand Down
Loading