Skip to content

feat: add Atlas Cloud LLM preset - #207

Open
binyangzhu000-sudo wants to merge 2 commits into
shenminglinyi:masterfrom
binyangzhu000-sudo:codex/add-atlas-cloud-provider
Open

feat: add Atlas Cloud LLM preset#207
binyangzhu000-sudo wants to merge 2 commits into
shenminglinyi:masterfrom
binyangzhu000-sudo:codex/add-atlas-cloud-provider

Conversation

@binyangzhu000-sudo

@binyangzhu000-sudo binyangzhu000-sudo commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • add an Atlas Cloud preset to the existing LLM control panel with https://api.atlascloud.ai/v1 and deepseek-ai/deepseek-v4-pro defaults
  • support ATLASCLOUD_API_KEY, ATLASCLOUD_BASE_URL, and ATLASCLOUD_MODEL during environment-backed initial configuration without changing existing provider priority
  • route the Atlas preset through the existing Chat Completions compatibility path, avoiding an unsupported Responses parsing path

Validation

  • focused LLM control/environment tests: 17 passed
  • application/infrastructure AI suite: 170 passed, 5 skipped, 1 unrelated existing failure
  • the same prompt-contract failure reproduces on the untouched upstream commit (fields_desc and genre_opening_profile are not declared)
  • Python 3.11 compileall and diff/secret checks
  • live request through PlotPilot LLMProviderFactory returned PLOTPILOT_ATLAS_OK using deepseek-ai/deepseek-v4-pro

No dependencies, lockfiles, frontend files, or README content changed.

Summary by CodeRabbit

  • New Features
    • Added support for configuring Atlas Cloud as an AI provider.
    • Atlas Cloud profiles include default connection and model settings.
    • Added options to customize the API key, base URL, and model.
    • Atlas Cloud can be selected explicitly or automatically when no other provider credentials are configured.
    • Atlas Cloud profiles automatically use compatible chat completion behavior.
  • Documentation
    • Added commented Atlas Cloud configuration examples to the environment template.

Signed-off-by: binyangzhu000-sudo <224954946+binyangzhu000-sudo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a4a19b1-d64b-4acf-b392-b3a311cc47f9

📥 Commits

Reviewing files that changed from the base of the PR and between a2c8213 and dd62b9e.

📒 Files selected for processing (1)
  • application/ai/llm_control_service.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • application/ai/llm_control_service.py

📝 Walkthrough

Walkthrough

Atlas Cloud support now includes environment settings, default values, an atlascloud profile preset, automatic provider selection, legacy Chat Completions handling, and unit tests for defaults, overrides, priorities, and profile resolution.

Changes

Atlas Cloud provider support

Layer / File(s) Summary
Atlas Cloud environment contract
.env.example, infrastructure/ai/llm_environment.py, tests/unit/infrastructure/ai/test_llm_environment.py
Adds Atlas Cloud settings, defaults, environment loading, fallback properties, example variables, and environment tests.
Atlas Cloud profile integration
application/ai/llm_control_service.py
Adds the atlascloud preset, legacy Chat Completions resolution, and Atlas Cloud profile initialization and priority handling.
Atlas Cloud service validation
tests/unit/application/ai/test_llm_control_service.py
Tests preset behavior, environment-driven initialization, provider priority, and profile resolution.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant LLMEnvironmentSettings
  participant LLMControlService
  participant AtlasCloudProfile
  LLMEnvironmentSettings->>LLMControlService: provide Atlas Cloud credentials and defaults
  LLMControlService->>AtlasCloudProfile: select or create atlascloud profile
  LLMControlService->>AtlasCloudProfile: enable legacy chat completions
Loading

Suggested reviewers: shenminglinyi

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the changes and validation, but it omits the required change type, architecture impact, risk, rollback, and checklist sections. Add the template sections for change type, architecture impact, risk and rollback, and test checklists; mark each applicable item explicitly.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding an Atlas Cloud LLM preset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@application/ai/llm_control_service.py`:
- Line 220: Update the description string near the service metadata to resolve
RUF001 by replacing the ambiguous fullwidth comma with an ASCII comma; preserve
the existing localized text and meaning.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a6e964b2-08cb-4ce8-86e9-44c2e466c8e9

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc03a3 and a2c8213.

📒 Files selected for processing (5)
  • .env.example
  • application/ai/llm_control_service.py
  • infrastructure/ai/llm_environment.py
  • tests/unit/application/ai/test_llm_control_service.py
  • tests/unit/infrastructure/ai/test_llm_environment.py

Comment thread application/ai/llm_control_service.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant