feature: additional validation and help messaging for shipthis game details and shipthis game create

[madebydavid]

This is to resolve #245

What's changed

• defined validation rules for each of the game details fields
• rules are documented https://github.com/shipth-is/cli/blob/245-feature-game-details-validation/docs/game/details.md#validation
• made use of the oclif error function which takes a ref and suggestions
• tests for the validation rules
• updated docs
• validates godot version too
• pulls list of supported versions from the backend

[madebydavid]

Performing some testing

gameEngineVersion

david@sal9000:~/game$ shipthis game details --gameEngineVersion 2.3
 ›   Error: "2.3" is not a Godot version that ShipThis builds.
 ›   Supported versions: 3.6, 4.0, 4.1, 4.2, 4.3, 4.4, 4.5, 4.6, 4.7. You can also pin a patch, such as 4.2.1.
 ›   Reference: https://shipth.is/docs/guides/godot-versioning

david@sal9000:~/game$ shipthis game ship --platform ios --gameEngineVersion 4.9
 ›   Error: "4.9" is not a Godot version that ShipThis builds.
 ›   Supported versions: 3.6, 4.0, 4.1, 4.2, 4.3, 4.4, 4.5, 4.6, 4.7. You can also pin a patch, such as 4.2.1.
 ›   Reference: https://shipth.is/docs/guides/godot-versioning
david@sal9000:~/game$ 

[madebydavid]

I don't like having a fixed list for the versions in the client - that will force people to upgrade to get the new version whereas the loose validation before meant they did not have to

[madebydavid]

The answer is to expose the supported versions on the API. Implementing a straightforward version of that now with a fallback to a constant

[Copilot]

Pull request overview

Adds contextual validation for game details across create, details, and ship workflows.

Changes:

• Adds field validators, warnings, and tests.
• Fetches supported Godot versions with a built-in fallback.
• Updates command flags, errors, and documentation.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/utils/validation.test.ts	Tests validation rules and warnings.
src/utils/validation.ts	Implements game-detail validation.
src/utils/index.ts	Exports validation utilities.
src/constants/index.ts	Adds constrained detail flags.
src/constants/godot.ts	Defines fallback Godot versions.
src/commands/game/ship.tsx	Validates version overrides.
src/commands/game/details.tsx	Validates detail updates.
src/commands/game/create.ts	Validates project creation inputs.
src/api/index.ts	Fetches supported Godot versions.
docs/game/ship.md	Documents ship validation.
docs/game/details.md	Documents validation rules.
docs/game/create.md	Documents create validation.

Suppressed comments (1)

src/commands/game/create.ts:68

• The detected-version warning also bypasses --quiet, despite the flag promising to suppress non-error output. Include !quiet in this condition.

    if (!details.gameEngineVersion && !isSupportedGodotVersion(detectedVersion, godotVersions)) {

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[madebydavid]

@copilot - updated that to address the outstanding ones - can you review the changes?

[Copilot]

@copilot - updated that to address the outstanding ones - can you review the changes?

I reviewed the latest updates in commit 8756060. The remaining review points are addressed (comment wording fixed and CLI flag parsing now trims values before validation/submission), and test/utils/validation.test.ts passes locally. I don’t see additional changes needed from my side.

[madebydavid]

Prod API is deployed to https://api.shipth.is/api/1.0.0/godot/versions

I will merge