fix(pstack): treat PI_SESSION_FILE as a named path - #15
Open
shishiv wants to merge 1 commit into
Open
Conversation
Transcript skills read the env path. They no longer invent a Cursor slug or warn that reading it crosses workspace boundaries. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Transcript skills described Cursor globbing.
$PI_SESSION_FILEis an explicit path. Reading it does not cross workspace boundaries.Scope
skills/recall/SKILL.mdnames the env path. TheUsers-you-projslug is gone.skills/poteto-mode/playbooks/eval.mdandsession-pickup.mdread that path and do not glob.skills/pstack-reflect/SKILL.mddrops thels -t <agent-transcripts>layout tutorial.skills/automate-me/SKILL.mdkeeps "use only that path" and drops the leftover clause.test/resources/resources.test.mjsbanscrosses workspace boundaries.src/workflows/sessions.tsis unchanged.skills/show-me-your-work/SKILL.mdis unchanged.Tradeoffs
The denylist grows by the leftover sentence this PR can make green. Banning
control-uinow would fail CI.Blast Radius
Agents that mine transcripts read
$PI_SESSION_FILEinstead of inventing a slug. JSONL is still one message per line.Verification
The denylist was added first and failed on
workspace-boundary leftover remains in active resources.node --test test/resources/resources.test.mjspassed (4 tests).npm run verify:deterministicpassed (format, lint, typecheck, 79 tests, manifest).rg "crosses workspace boundaries" skills agents automationsis empty.rg "Users-you-proj" skills agents automationsis empty.Made with Cursor