fix: port of imageproxy was wrong#2269
Open
tinect (tinect) wants to merge 1 commit intoshopware:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the installation documentation to reflect the correct internal port for the imageproxy container so the proxy can be reached via the intended host port.
Changes:
- Update the
imageproxyDocker Compose port mapping from8050:80to8050:8000.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
185
to
+189
| services: | ||
| imageproxy: | ||
| image: ghcr.io/shopwarelabs/devcontainer/image-proxy | ||
| ports: | ||
| - "8050:80" | ||
| - "8050:8000" |
There was a problem hiding this comment.
The YAML example becomes invalid because the ports list item is not indented under ports: (it currently starts at the beginning of the line). Please indent the - "8050:8000" line to be a child of ports: (and ideally normalize indentation for the whole services/imageproxy block so the snippet can be copy-pasted into compose.override.yaml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the imageproxy starts at port 8000
Related links
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted..wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Notes