docs/billie_jean.md: update scheduler section from ms time= to ticks= - #1032
Merged
Conversation
The "Using the AMY scheduler" section still taught the removed millisecond e.time API and the old config_reverb() call. Bring it in line with what BillieJeanScheduled.ino actually does now: tempo set by event, reverb configured by event fields, scheduling via e.ticks[0] absolute sequencer ticks with a grace_ticks lead (past events are dropped), and the loop clocked off sequencer_ticks() instead of millis(). Also explains the 48 PPQ sequencer clock and the amy_ticks_per_tick conversion, and mentions the period/tag forms in passing. The first two sections are untouched: their sketches deliberately keep wall-clock time themselves with millis(), and still do. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Using the AMY scheduler" section of the Billie Jean tutorial still taught the removed millisecond
e.timeAPI (and the oldconfig_reverb()call), while BillieJeanScheduled.ino has already moved on. This brings the doc in line with what the sketch actually does:e.tempo = 116), reverb configured by event fields;e.ticks[0]absolute sequencer ticks, with thegrace_tickslead the sketch uses (and an explanation of why: events scheduled in the past are dropped);sequencer_ticks()instead ofmillis();amy_ticks_per_tickeighth-note conversion, and a one-line pointer to the period/tag forms ofticks.The first two sections (BillieJeanDrums, BillieJeanDrumsBass) are untouched: those sketches deliberately keep wall-clock time themselves with
millis(), and still do — theirmillis_per_tickis sketch-local, not the removed AMY API.Doc-only change.
🤖 Generated with Claude Code