fix: keep the timeline length when a generated clip replaces its placeholder - #211
Merged
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
## [2.23.1](v2.23.0...v2.23.1) (2026-09-29) ### Bug Fixes * keep the timeline length when a generated clip replaces its placeholder ([#211](#211)) ([a1ea93b](a1ea93b))
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating the last clip on the timeline shortened the edit.
totalDurationfell back to the end of the previous clip, so playback and seeking stopped there and the canvas showed nothing past it, while the timeline still drew the clip.When generation fills a prompt clip's
src, the reconciler replaces its placeholder player. Disposing the placeholder recalculates the duration before the replacement exists, and adding the replacement did not recalculate it.reconcile()now recalculates once every player is in place;updateTotalDurationemitsDurationChangedonly when the value changes.Verify:
npm run typecheck,npm run lint,npm test(2,159 passing; the new test gets 5 instead of 10 without the fix),npm run build,npm run test:package.