Skip to content

refactor(test): simplify error handling in futures write tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiagosiebler merged 1 commit into from
Sep 24, 2026
Merged

refactor(test): simplify error handling in futures write tests #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions test/integration/rest/private.futures.write.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
import { FuturesClient } from '../../../src/index.js';
import { getTestProxy } from '../proxy.util.js';

function validateFuturesKeyPermissionException(e: unknown) {
const err = e as { body?: Record<string, unknown> };
expect(err).toBeDefined();
expect(err.body).toBeDefined();
// Linear-swap now returns HTTP 200 + { status: "error", err_code: 403, err_msg: null }.
// Signature is valid; the key has no trade permission. Do not require err_msg text.
expect(err.body?.status).toBe('error');
expect(err.body?.err_code).toBe(403);
}

describe('REST PRIVATE FUTURES WRITE', () => {
const account = {
key: process.env.API_FUTURES_KEY,
Expand Down Expand Up @@ -60,13 +70,8 @@ describe('REST PRIVATE FUTURES WRITE', () => {
expect(res.data).toBeDefined();
} catch (e: unknown) {
// Expected: invalid key permission error
const body = (e as { body?: Record<string, unknown> })?.body;

// console.log(`err "${expect.getState().currentTestName}"`, { body, e });
expect(body).toBeDefined();

const errorMsg = body?.err_msg;
expect(errorMsg).toMatch(/no permission/i);
validateFuturesKeyPermissionException(e);
}
});

Expand Down Expand Up @@ -98,16 +103,11 @@ describe('REST PRIVATE FUTURES WRITE', () => {
expect(res.data).toBeDefined();
} catch (e: unknown) {
// Expected: invalid key permission error
const body = (e as { body?: Record<string, unknown> })?.body;

// console.error(`err "${expect.getState().currentTestName}"`, {
// body,
// e,
// });
expect(body).toBeDefined();

const errorMsg = body?.err_msg;
expect(errorMsg).toMatch(/no permission/i);
validateFuturesKeyPermissionException(e);
}
});

Expand All @@ -121,11 +121,7 @@ describe('REST PRIVATE FUTURES WRITE', () => {
expect(res).toBeDefined();
} catch (e: unknown) {
// Expected: order not found - validates signature
const body = (e as { body?: Record<string, unknown> })?.body;
expect(body).toBeDefined();

const errorMsg = body?.err_msg;
expect(errorMsg).toMatch(/no permission/i);
validateFuturesKeyPermissionException(e);
}
});

Expand All @@ -139,11 +135,7 @@ describe('REST PRIVATE FUTURES WRITE', () => {
expect(res).toBeDefined();
} catch (e: unknown) {
// Expected: order not found - validates signature
const body = (e as { body?: Record<string, unknown> })?.body;
expect(body).toBeDefined();

const errorMsg = body?.err_msg;
expect(errorMsg).toMatch(/no permission/i);
validateFuturesKeyPermissionException(e);
}
});
});
Expand Down
Loading