fix(filtered-search): prevent free-text input from collapsing with multiple criteria#2118
fix(filtered-search): prevent free-text input from collapsing with multiple criteria#2118spliffone wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic input sizing for the free-text and typeahead filtered search components by binding the size attribute to a new computed property, valueInputSize, in the base class. However, the current implementation of valueInputSize uses a type assertion (value as string) that bypasses TypeScript's type safety. This will cause incorrect size calculations when multiSelect is enabled and the value is an array of strings. To resolve this, the computed property should explicitly handle array values by joining them before determining the length.
spliffone
force-pushed
the
fix/filtered-search-grow-criteria-input
branch
from
69a67ef to
f5009df
Compare
…ltiple criteria Set min-inline-size: 20ch to ensure the free-text input maintains a minimum width when multiple filter criteria are configured, improving usability and visual stability.
spliffone
force-pushed
the
fix/filtered-search-grow-criteria-input
branch
from
a6e5936 to
cdb2515
Compare
spliffone
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request modifies the SCSS of the filtered search input component to set a minimum inline size of 20ch on the input element. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Set min-inline-size: 20ch to ensure the free-text input maintains a minimum
width when multiple filter criteria are configured, improving usability and
visual stability.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: