ENG-5438 Add Export Service Definition - #310
Merged
dengjonathan merged 6 commits intoSep 12, 2025
Merged
Conversation
dengjonathan
force-pushed
the
eng-5438-public-sift-client-doesnt-contain-exportservice-protos
branch
from
September 10, 2025 20:41
8d41ae9 to
dab7c86
Compare
dengjonathan
requested review from
bgfreeman7
and removed request for
bgfreeman7
September 10, 2025 20:43
…c-sift-client-doesnt-contain-exportservice-protos
marc-sift
reviewed
Sep 12, 2025
Contributor
|
Should also include the .proto file. |
Contributor
Author
Contributor
Author
confirmed that adding the cleanup step at the end of the gen script allows generation ok without error
|
marc-sift
approved these changes
Sep 12, 2025
dengjonathan
deleted the
eng-5438-public-sift-client-doesnt-contain-exportservice-protos
branch
September 12, 2025 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup ticket to add the Export Service definition to the client library. When developing a new export feature I was trying to use an API client to test the export service responses in different cases but noticed it wasn't included in the client library.
I directly copied the proto from the app's definition here: https://github.com/sift-stack/azimuth/tree/main/protos/sift/exports/v1
And then ran:
make genmake sanitize