fix: update sqlx and sqlite bindings for iOS simulator builds#48
fix: update sqlx and sqlite bindings for iOS simulator builds#48polw1 wants to merge 1 commit intosilvermine:masterfrom
Conversation
|
Thanks @polw1. This PR includes several different changes. Are all of them necessary to resolve the issue, or are some just side effects of the dependency updates? Is it possible to simplify this down to the minimal required changeset? |
1a8ad30 to
d0ee8ec
Compare
|
I had kept But I removed it as requested. |
|
Thanks @polw1. My question is more: What is the root change that triggered all of these changes? (And are all of them necessary)? Particularly the code-level changes. |
|
The root change is the The original issue comes from the fact that So the minimal dependency change was:
The code-level changes are required by that
I’m sorry for not explaining it better before |
|
That makes sense. My main concern is moving to an alpha package, especially given the number of breaking changes in the 0.9.x line. Could we get a sense of when 0.9.0 stable is expected to land before we commit? |
|
I agree with that concern, and I was thinking the same thing. As far as I can tell, I’m going to move this PR back to draft and keep watching the SQLx release line. My concern is also the delay: if stable takes a while, we would be carrying an alpha dependency longer than we’d like. |
Upgrade the SQLx/SQLite dependency chain so iOS simulator builds no longer
depend on BINDGEN_EXTRA_CLANG_ARGS in .cargo/config.toml.