Skip to content

feat: export query function#15

Open
titanism wants to merge 1 commit into
silverwind:masterfrom
titanism:patch-1
Open

feat: export query function#15
titanism wants to merge 1 commit into
silverwind:masterfrom
titanism:patch-1

Conversation

@titanism
Copy link
Copy Markdown

@titanism titanism commented Mar 2, 2023

This exports the query function so that users can use custom resolver options, e.g. 🍊 Tangerine which supports DNS over HTTPS ("DoH").

This exports the `query` function so that users can use custom `resolver` options, e.g. 🍊 [Tangerine](https://github.com/forwardemail/tangerine) which supports DNS over HTTPS ("DoH").
@titanism
Copy link
Copy Markdown
Author

titanism commented Mar 2, 2023

It would be nice to be able to pass a custom resolver from the get-go. Also - the timeout stuff should be configurable or if you pass a custom resolver it should be disabled, because otherwise it'd cancel all dns requests because it calls .cancel() method. Maybe an AbortController is better - or leave it up to the user - and tell them this in the README.

@silverwind
Copy link
Copy Markdown
Owner

silverwind commented Mar 18, 2023

Hmm I think it's better to introduce a opts.resolver option on the public APIs lookup and batch. Exporting this "dirty" internal function seems wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants