Skip to content

feat: mount compiled room from runtime bundle - #789

Merged
gidich merged 2 commits into
mainfrom
wt/bothy-tsk_e878ee63934a36f5
Sep 4, 2026
Merged

feat: mount compiled room from runtime bundle#789
gidich merged 2 commits into
mainfrom
wt/bothy-tsk_e878ee63934a36f5

Conversation

@gidich

@gidich gidich commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • load reviewed compiled room GLBs from the learner runtime bundle
  • wire the loader into the live station scene and retain the parametric fallback
  • reject fixture, blocked, or identity-mismatched room assets and record load-failure evidence

Verification

  • focused compiled-room and station-environment tests: 9 passed
  • pnpm --filter @openclinxr/ui-xr typecheck

Review

The first revision exposed an unused resolver. Orchestrator review rejected it; this revision wires createStationScene to the runtime adapter and includes a source guard against regression to the direct parametric call.

No Infinigen-quality, live Azurite, clinical-validity, or Quest-readiness claim.

t added 2 commits September 4, 2026 12:27
When encounter materialization supplies compiledRoomAssetUrl + compileNodeId,
resolveStationEnvironment loads that GLB and tags compile-node userData instead
of spawning the parametric box. Missing URL keeps buildStationEnvironment.
createStationScene now awaits mountStationEnvironmentForRuntime with the
active environmentId and encounterRuntimeAssetBundle.environment. Fixture
shells and identity mismatches stay parametric. Infinigen overlay is skipped
when the compiled compile-node shell is already the primary.
@gidich
gidich merged commit ac77f96 into main Sep 4, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant