introduce nom parser - #7
Open
JamesFysh wants to merge 2 commits into
Open
Conversation
… minor bug-fixes for the existing parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR was a bit messed up (changed made on master, initially going back to upstream master). Also, the unit-tests involved even more copy-paste activity than I would usually put up with, even for unit-test code.
Unit-tests are now pushed out to a separate module and written in a way that reduces the amount of boiler-plate required. Tests for both the old and new parser live in the same file. Two unit-tests fail (for the old parser, only), leading to a question: Fix the old, or migrate to the new?