Repository navigation
Add set_hvac - #267
Merged
Merged
Add set_hvac#267
Conversation
mmccrackan
marked this pull request as draft
October 2, 2026 15:38
mmccrackan
marked this pull request as ready for review
October 2, 2026 16:08
BrianJKoopman
left a comment
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
This looks good, just one question I'm wondering about. (And thanks for adding tests!)
BrianJKoopman
self-requested a review
October 5, 2026 13:19
BrianJKoopman
approved these changes
Oct 5, 2026
BrianJKoopman
left a comment
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for adding to that docstring!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
set_hvacfor turning on the LAT boosters and fans.