perf(terminal): reduce search and frame update overhead - #65
Merged
Conversation
Reduce allocation and copying during scrollback search and incremental redraws by reusing query scratch space, retaining pane instances, and sharing snapshot rows. Preserve Unicode match positions and rendered output with regression coverage. Validation: workspace build and formatting checks pass; the serial workspace run passes 2,499 tests. Record release measurements and the existing intermittent PTY buffer-reuse test in the performance log.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search highlighting scans all matches for each rebuilt row, query scans allocate scratch buffers per row, and partial redraws copy unchanged pane instances. Synchronized output also deep-copies held frames. Reduce this repeated work while preserving Unicode search positions, navigation, and rendered pixels.
Arc<Vec<Row>>, preserving independent display metadata and allocation reuse when ownership is unique.Validation
cargo build --workspace --locked --offlinecargo fmt --all -- --checkcargo test --workspace --locked --offline -- --test-threads=1— 2,499 passed, 15 ignored.cargo test -p noa-grid -p noa-render --release --lib performance_probe --locked --offline -- --ignored --nocapture— three paired runs.Measurements
Local arm64 macOS 26.6.2, release build; medians of three isolated runs:
日本, 20,000 rowsThese measure the local mechanisms rather than application frame rate or end-to-end input latency. Search remains synchronous. Full conditions and results are in
docs/performance-measurements.md.Review notes
FrameSnapshot.rowsnow usesArc<Vec<Row>>; workspace constructors and the benchmark consumer are updated. Pending uploads and snapshot ownership are covered by regression tests; no configuration or persisted format changes are required.The unchanged PTY test
reader_reuses_returned_payload_buffersfailed once in a parallel workspace run, then passed both an isolated rerun and the complete serial run. Its stabilization is recorded as a separate follow-up in the measurement log.