Skip to content

Manual pageview callback never runs when the pageview is skipped #130

Open

Description

@simpleanalytics-agent

What

sa_pageview(path, callback) only calls the callback when a request is sent. When the pageview is skipped, for example a repeated path or a path excluded by data-ignore-pages, the callback never runs.

  • Expected: the callback runs once for every sa_pageview call that passes one.
  • Current: sa_pageview("/same", cb1); sa_pageview("/same", cb2) sends one request and only calls cb1.

Why

Sites that continue navigation or other flow from the callback hang when the pageview is skipped.

Notes

Callback support is new in v12 (scripts#40). Reported in this review thread.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions