show error when cluster is not found in namespace#239
Closed
boddumanohar wants to merge 1 commit into
Closed
Conversation
boddumanohar
force-pushed
the
show-error-when-cluster-not-found-in-ns
branch
from
July 24, 2026 13:55
9a3361f to
173b8bb
Compare
Member
Author
|
we already have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Originally this PR set out to fix a confusing reconcile loop when a
Poolis applied in anamespace that doesn't contain its
StorageCluster:A
Poolcan only be reconciled in the same namespace as itsStorageCluster; this case wasn'tsurfaced as a clear error on the CR, so it just looked like the cluster was slow to come up.
Current state
While rebasing, that underlying bug was found to already be fixed on
main(via #349/relatedwork):
ResolveClusterUUIDnow returns a dedicatedErrClusterNotFoundsentinel, and the poolcontroller's
Reconciledistinguishes it from a not-yet-ready UUID — settingPool.Status.Status = "InvalidClusterReference", emitting a Warning event, and requeuing at aslower interval, instead of looping silently.
This PR is now scoped down to what's left on top of that: adding a generic
Conditions []metav1.Conditionfield (with aConditionTypePoolReadyconstant) toPool.Status, matchingthe condition pattern already used elsewhere (e.g.
SnapshotReplication), so future poolreconcile states can be surfaced via
kubectl describein a standard way. CRD manifests areregenerated and synced to
helm-chartsaccordingly.No controller logic changes in this PR — the existing
InvalidClusterReferencehandling onmainis left as-is.