feat(copilot): add share_file tool + surface file share state to the agent#5656
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview API hardening: When re-enabling a share without passing Agent visibility: Workspace VFS file metadata gains batched Reviewed by Cursor Bugbot for commit 2b09aff. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
@greptile review |
Greptile SummaryThis PR adds Copilot support for sharing workspace files. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (8): Last reviewed commit: "feat(copilot): add share_file tool handl..." | Re-trigger Greptile |
|
472a037 to
1673192
Compare
|
@greptile review Addressed the auth-type validation finding: |
1673192 to
1d76a7e
Compare
|
@greptile review Addressed both findings:
|
1d76a7e to
9e1e71a
Compare
|
@greptile review Added |
9e1e71a to
aa55758
Compare
|
@greptile review Rebased onto latest staging and resolved conflicts (staging's |
aa55758 to
b84e758
Compare
|
@cursor review |
…te to the agent Implement the sim-side share_file server tool (resolves VFS path to file, keeps the existing org-policy + permission + audit checks, delegates to upsertFileShare). Register it in the tool router and generated catalog. Stamp an ambient 'shared'/'shareAuthType' flag onto file metadata via one batched share lookup, mirroring how workflows expose 'isDeployed'. Validate the EFFECTIVE auth type when re-enabling a share: upsertFileShare preserves an existing share's authType when none is passed, so validate the stored mode (not 'public') or a re-share could reactivate a now-disallowed password/email/sso share. Same fix applied to the share PUT route.
b84e758 to
2b09aff
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2b09aff. Configure here.
Summary
share_fileserver tool handler: resolves a VFSpathto the file, keeps the existing checks (org public-sharing policy, write/admin permission,ShareValidationError, and theFILE_SHARED/FILE_SHARE_DISABLEDaudit), then delegates to the sharedupsertFileShare— same path the files UI usesshared/shareAuthTypeflag on each file's metadata via one batched share lookup (no N+1), so the agent can see andgrepwhat's shared — mirrors how workflows exposeisDeployedPairs with
mship-tools:checkregenerates the catalog from the copilot repo'stool-catalog-v1.json, so this PR's check stays red until fix(deps): bump the dependencies group in /apps/sim with 4 updates #353 lands.Type of Change
Testing
tsc --noEmit0 errors;bun run lint:checkandcheck:api-validation:strictpass; biome cleanChecklist
Companion: simstudioai/mothership#353