Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/sim/components/emails/components/email-footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ export function EmailFooter({
fontFamily: typography.fontFamily,
}

/**
* Social icons are linked images. `display: block` removes the 2–3px gap
* Outlook adds under inline images, and `border: 0` prevents the blue link
* border older Outlook versions draw around linked images.
*/
const socialIconStyle = {
display: 'block' as const,
border: 0,
}

return (
<Section
style={{
Expand Down Expand Up @@ -77,6 +87,7 @@ export function EmailFooter({
width='20'
height='20'
alt='X'
style={socialIconStyle}
/>
</Link>
</td>
Expand All @@ -87,6 +98,7 @@ export function EmailFooter({
width='20'
height='20'
alt='LinkedIn'
style={socialIconStyle}
/>
</Link>
</td>
Expand All @@ -97,6 +109,7 @@ export function EmailFooter({
width='20'
height='20'
alt='GitHub'
style={socialIconStyle}
/>
</Link>
</td>
Expand All @@ -107,6 +120,7 @@ export function EmailFooter({
width='20'
height='20'
alt='Slack'
style={socialIconStyle}
/>
</Link>
</td>
Expand Down
4 changes: 2 additions & 2 deletions apps/sim/components/emails/components/email-layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ export function EmailLayout({
<Section style={baseStyles.header}>
<Img
src={brand.logoUrl || `${baseUrl}/brand/color/email/wordmark.png`}
height='34'
{...(hasCustomLogo ? {} : { width: '70' })}
height='41'
{...(hasCustomLogo ? {} : { width: '68' })}
Comment on lines +57 to +58

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Custom Logos Inherit Wordmark Height

When brand.logoUrl is configured, this branch now enlarges that custom logo from 34px to 41px even though the new height is specific to the padded bundled wordmark. Wide or tall custom assets can expand the email header or appear oversized; retain the old height for custom logos.

Suggested change
height='41'
{...(hasCustomLogo ? {} : { width: '68' })}
height={hasCustomLogo ? '34' : '41'}
{...(hasCustomLogo ? {} : { width: '68' })}

alt={brand.name}
style={hasCustomLogo ? { display: 'block', width: 'auto' } : { display: 'block' }}
/>
Expand Down
Binary file modified apps/sim/public/brand/color/email/wordmark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/sim/public/static/github-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/sim/public/static/linkedin-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/sim/public/static/slack-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/sim/public/static/x-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading