You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to fix(emails): sharpen wordmark, add clear space, and standardize footer icon sizes #5802. That PR bumped the header logo height from 34 → 41 to fit the newly padded default wordmark, but the height prop was applied unconditionally — so configured custom/whitelabel logos (brand.logoUrl) also inherited the 41px height and rendered oversized.
Make height conditional alongside width: custom logos keep their original height='34' (width auto); only the default padded wordmark uses 41×68.
This is the P1 Greptile flagged on #5802 before it was merged.
Low Risk
Small presentation-only change in shared email layout with no auth, data, or API impact.
Overview
Fixes a regression where all email header logos used height='41' after the default wordmark sizing update, which made custom whitelabel logos (brand.logoUrl) render too tall.
In email-layout.tsx, logo dimensions are now applied the same way as width: custom logos get height='34' with auto width; the default wordmark keeps height='41' and width='68'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
34→41to fit the newly padded default wordmark, but theheightprop was applied unconditionally — so configured custom/whitelabel logos (brand.logoUrl) also inherited the41pxheight and rendered oversized.heightconditional alongsidewidth: custom logos keep their originalheight='34'(width auto); only the default padded wordmark uses41×68.This is the P1 Greptile flagged on #5802 before it was merged.
Type of Change
Testing
Verified the JSX branches:
hasCustomLogo→height='34'only; default →height='41' width='68'. Lint clean.Checklist