Skip to content

fix(emails): keep custom whitelabel logos at their original height#5803

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/email-custom-logo-height
Jul 21, 2026
Merged

fix(emails): keep custom whitelabel logos at their original height#5803
waleedlatif1 merged 1 commit into
stagingfrom
fix/email-custom-logo-height

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to fix(emails): sharpen wordmark, add clear space, and standardize footer icon sizes #5802. That PR bumped the header logo height from 3441 to fit the newly padded default wordmark, but the height prop was applied unconditionally — so configured custom/whitelabel logos (brand.logoUrl) also inherited the 41px height and rendered oversized.
  • Make height conditional alongside width: custom logos keep their original height='34' (width auto); only the default padded wordmark uses 41×68.

This is the P1 Greptile flagged on #5802 before it was merged.

Type of Change

  • Bug fix

Testing

Verified the JSX branches: hasCustomLogoheight='34' only; default → height='41' width='68'. Lint clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 21, 2026 5:58pm

Request Review

@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small presentation-only change in shared email layout with no auth, data, or API impact.

Overview
Fixes a regression where all email header logos used height='41' after the default wordmark sizing update, which made custom whitelabel logos (brand.logoUrl) render too tall.

In email-layout.tsx, logo dimensions are now applied the same way as width: custom logos get height='34' with auto width; the default wordmark keeps height='41' and width='68'.

Reviewed by Cursor Bugbot for commit d440732. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores the intended email logo sizing for custom branding.

  • Keeps custom and whitelabel logos at 34px high with automatic width.
  • Keeps the default padded wordmark at 41×68px.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/components/emails/components/email-layout.tsx Conditionally sizes custom logos at 34px high and the default wordmark at 41×68px.

Reviews (1): Last reviewed commit: "fix(emails): keep custom whitelabel logo..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 53f8ce5 into staging Jul 21, 2026
15 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/email-custom-logo-height branch July 21, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant