Skip to content

fix(build): avoid Turbopack chunk collision with GCS path rename - #7593

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/staging-demo-readiness
Sep 8, 2026
Merged

TheodoreSpeaks merged 1 commit into
stagingfrom
codex/staging-demo-readiness

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Rename the GCS upload provider directory to google-cloud-storage and update imports to avoid a Turbopack chunk filename collision.
  • Keep Next.js 16.3.1, Turbopack, dependencies, and upload behavior unchanged.

Type of Change

  • Bug fix

Testing

Clean production build and TypeScript passed with the existing 8 GB build setting. All 114 focused upload/storage tests, lint, 46 repository audits, and docs manifest validation passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 8, 2026 2:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR renames the GCS upload-provider directory to prevent a Turbopack chunk-name collision while preserving the existing provider identity and behavior.

  • Updates every static and dynamic import to providers/google-cloud-storage.
  • Moves the GCS implementation, types, and tests without behavioral changes.
  • Leaves the runtime and persisted provider identifier as gcs.

Confidence Score: 5/5

The PR appears safe to merge because the directory rename is complete and preserves the existing GCS runtime contract.

No actionable failures remain: all old provider-path references were migrated, test discovery still includes the moved test, and provider configuration and persisted identifiers continue to use gcs.

Important Files Changed

Filename Overview
apps/sim/lib/uploads/core/storage-client.ts Updates the lazy GCS metadata-client import to the renamed provider path.
apps/sim/lib/uploads/core/storage-service.ts Updates GCS types and all storage-operation dynamic imports consistently.
apps/sim/lib/uploads/providers/google-cloud-storage/client.ts Moves the existing GCS client and updates its local type import without changing behavior.
apps/sim/lib/uploads/providers/google-cloud-storage/client.test.ts Moves the existing GCS test suite and updates its client import.
apps/sim/lib/uploads/providers/google-cloud-storage/types.ts Moves the unchanged GCS provider type definitions.
apps/sim/lib/uploads/upload-session/provider.ts Updates every upload-session GCS dynamic import to the renamed provider module.

Reviews (1): Last reviewed commit: "fix(build): avoid Turbopack chunk collis..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 1f6eef3 into staging Sep 8, 2026
33 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/staging-demo-readiness branch September 8, 2026 14:48
waleedlatif1 added a commit that referenced this pull request Sep 24, 2026
…nk name collision

Turbopack truncates chunk content hashes to seven characters (vercel/next.js#97765), and this branch's module graph produced two different server chunks with the same name, failing the build. Renaming the module re-rolls the hash, as #7593 did; the collision can recur on unrelated changes until Next ships untruncated hashes.

This branch was previously deployed

1 inactive deployment
Preview — 54311542 Deployed Sep 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants