fix(logging): name the driver cause and redact bound params in logged errors - #8565
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
\nparams: <values>tail from a logged error's message and stack (and the OTel export) — bound values are user data and were reaching every DB error log lineerrorCause/errorCodefrom the deepest.cause, so a wrappedDrizzleQueryErrornames the real reason (statement timeout, constraint violation) instead of only the failing SQLloadDeployedWorkflowStateno longer logsNoActiveDeploymentErrorat ERROR — an undeployed workflow is an outcome every caller already handles (custom-block input derivation returns[], read models returnnull, executions fail the run with their own log). Real load failures still logdescribeError/redactBoundParametersfrom@sim/utils/errors;errorstays a plain message string so log grouping is unchangedType of Change
Testing
wrapped driver errorscases inpackages/logger/src/index.test.ts(bare error,{ error }, other key, OTel export, unwrapped negative control); each written first and shown red on the pre-fix logger, and each guard reverted individually to confirm its test failsbun run test(all workspaces green; one unrelated CPU-timeout inremark-plain-text.test.tsunder full-suite load passes in isolation)bun run type-checkinpackages/loggerandapps/sim,bun run lint,check-block-registry,bun run check:audits,docs-manifest:checkChecklist
test-auditauthoring gate)