Skip to content

improvement(tools): stop exporting tool types used only in their own file - #8597

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/tool-types-file-local
Oct 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/tool-types-file-local

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to improvement(tools): delete unreferenced tool response types and the dead generic resource data path #8596. In apps/sim/tools/*/types.ts, 406 interface/type declarations used only inside their own file lose export; 32 used nowhere are deleted (27 baselined plus 5 private types only they referenced), and one dead re-export goes from microsoft_dynamics_365/index.ts.
  • Types only: every added line is a non-exported interface/type declaration, and no const or function line changes. The *_OUTPUT_PROPERTIES consts stay exported because generate-docs.ts resolves them by export const; generated docs are unchanged.
  • check:unused-exports baseline shrinks by 434 entries; the tools/*/types.ts bucket now holds only those consts and a few helper functions.

Type of Change

  • Improvement

Testing

  • bun run lint, bun run type-check, bun run check:audits (58, incl. docs:check and check:unused-exports), docs-manifest:check, block-registry check, root bun run test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

…file

- Drop `export` from 406 tool types referenced only inside their own types.ts
- Delete 27 tool types used nowhere, plus 5 private param types only they referenced
- Remove the dead `DataverseResponse` re-export from microsoft_dynamics_365/index.ts
- Shrink check-unused-exports baseline by 434 entries; `export const` output schemas untouched
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 3, 2026 8:43am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Removes export keywords from internal type definitions.

The PR appears safe to merge; no actionable issue was established.

Summary

The PR makes file-local tool types private, removes unused declarations and a dead re-export, and shrinks the unused-exports baseline. No actionable issue was established.

Reviews (1) · Last reviewed commit: "improvement(tools): stop exporting tool ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 108 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 55de876 into staging Oct 3, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/tool-types-file-local branch October 3, 2026 08:54

This branch was successfully deployed

1 active deployment
Preview — aa25cac7 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant