You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reject tool request URLs whose path contains a . or .. segment (incl. %2e spellings) before dispatch, so an id param interpolated into a URL template can't traverse to another endpoint
Central check in the shared request transport, so it covers every URL-builder tool
A hand-written HTTP Request URL containing a literal .. segment is now rejected too
Type of Change
Bug fix
Testing
tools/request-transport.test.ts: new traversal cases fail without the guard; registry probe now requires benign URLs to pass and injected .. ids to be rejected
tools/ + executor/handlers suites, lint, type-check, check:audits, docs-manifest:check, root bun run test (2 unrelated timing flakes, pass on rerun)
Checklist
Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
[Medium risk] Adds path traversal validation to tool request URLs.
The PR appears safe to merge; no outstanding blocking finding was established.
Summary
The PR adds a shared pre-dispatch check for dot path segments in external tool request URLs and tests both rejected traversal paths and allowed non-segment dots.
The latest revision tightens the registry probe’s assertions and aligns boundary-whitespace handling with URL parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.or..segment (incl.%2espellings) before dispatch, so an id param interpolated into a URL template can't traverse to another endpoint..segment is now rejected tooType of Change
Testing
tools/request-transport.test.ts: new traversal cases fail without the guard; registry probe now requires benign URLs to pass and injected..ids to be rejectedtools/+executor/handlerssuites,lint,type-check,check:audits,docs-manifest:check, rootbun run test(2 unrelated timing flakes, pass on rerun)Checklist
test-auditauthoring gate)🤖 Generated with Claude Code