Skip to content

fix(desktop): open Folder Access from a focused utility window - #8855

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-8853-review
Oct 9, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-8853-review

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • File → Folder Access now anchors to the focused window, falling back to the main window, through focusedWindowOrMain. While a utility window such as Server settings had focus, focusedMainOrFallback returned null and the menu item did nothing.
  • Resource-scoped commands (tabs, zoom, history, reload) keep the main-window-only restriction.

Type of Change

  • Bug fix

Testing

  • New step in the Electron E2E e2e/local-files.spec.ts: opens File → Server… in the real app, waits for the sheet to show, then runs File → Folder Access with that window focused and asserts that the access menu pops up over it with "Add Folder…". On the previous code the step fails because no menu opens. The full spec passes locally on macOS.
  • Desktop suite: 84 files, 1072 tests passed. Desktop type-check, bun run lint, bun run check:audits (58 audits) and test:scripts passed.
  • Root bun run test: every workspace passed except two apps/sim tests that hit the 10s timeout under full-suite load; both pass when run alone.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 9, 2026 5:21pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] No new blocking issue was found in the changes since the previous review.

Summary

File → Folder Access now uses the focused utility window, with the main window as the fallback.

  • Resource commands keep their main-window-only restriction.
  • The mock-call unit test was removed. A replacement Electron test records the popup’s target and menu items.

Reviews (2) · Last reviewed commit: "test(desktop): cover Folder Access from ..." · Reviewed by Greptile

Comment thread apps/desktop/src/main/menu.test.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 970e030 into staging Oct 9, 2026
40 of 41 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-8853-review branch October 9, 2026 17:26

This branch was previously deployed

1 inactive deployment
Preview — 8cdfaae6 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant