Repository navigation
fix(projects): gate the Project list on the projects rollout flag - #9052
Merged
Merged
Conversation
…403 when it is off
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge. SummaryGates the Project Issues picker behind the server-resolved
Reviews (2) · Last reviewed commit: "fix(projects): keep the disabled-flag 50..." · Reviewed by Greptile |
# Conflicts: # apps/sim/lib/projects/README.md
Collaborator
Author
|
@greptileai review |
Collaborator
Author
|
@cubic-dev-ai review |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/projectswithout checking theprojectsrollout flag, so with the flag off every open of the features tab hit a disabled API, got its 503, and produced a server error loguseProjectsnow reads a server-resolvedprojectsflag (FeatureFlagsProvider, resolved once in the workspace and organization layouts viaisProjectsEnabled()) and never requests while it is offType of Change
Testing
project-issue-restrictions.test.tsx: flag off → no/api/projectsrequest; flag on → Projects listed; Projects loaded with the flag on are hidden after remounting with it off (first and third fail before the change)Checklist