Skip to content

fix(projects): gate the Project list on the projects rollout flag - #9052

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/projects-gating
Oct 15, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/projects-gating

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The access-control group editor's Project Issues picker called GET /api/projects without checking the projects rollout flag, so with the flag off every open of the features tab hit a disabled API, got its 503, and produced a server error log
  • useProjects now reads a server-resolved projects flag (FeatureFlagsProvider, resolved once in the workspace and organization layouts via isProjectsEnabled()) and never requests while it is off
  • The picker also renders nothing while the query is disabled, so Projects cached before the flag turned off are not offered
  • Kept the disabled-flag response at 503: realtime's Project file rooms treat 503 from the access callbacks as transient (keep membership, retryable writes) and 403/404 as revocation (evict + broadcast), so switching to 403 would turn a kill-switch flip into evicting every open Project document

Type of Change

  • Bug fix

Testing

  • project-issue-restrictions.test.tsx: flag off → no /api/projects request; flag on → Projects listed; Projects loaded with the flag on are hidden after remounting with it off (first and third fail before the change)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 15, 2026 12:09am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 10 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/hooks/queries/projects.ts
@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Gates the Project Issues picker behind the server-resolved projects flag.

  • The Project Issues picker follows the Projects rollout flag.

Reviews (2) · Last reviewed commit: "fix(projects): keep the disabled-flag 50..." · Reviewed by Greptile

Comment thread apps/sim/ee/access-control/components/project-issue-restrictions.tsx Outdated
@waleedlatif1 waleedlatif1 changed the title fix(projects): gate the Project list on the projects flag and answer 403 when it is off fix(projects): gate the Project list on the projects rollout flag Oct 15, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptileai review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 93249e5 into staging Oct 15, 2026
53 of 54 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/projects-gating branch October 15, 2026 00:18

This branch was successfully deployed

1 active deployment
Preview — 32734a0b Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant