Skip to content

feat(chat): recall sent messages from composer - #9289

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-composer-history
Oct 21, 2026
Merged

feat(chat): recall sent messages from composer#9289
waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-composer-history

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Up/Down recall of sent messages in chat composers, with queued-message priority and protection for drafts, selections, multiline editing, and IME input.
  • Restore skills, MCP mentions, resources, and uploads through the shared message parser; preserve context identifiers across reloads and identify historical selections that need reattaching.
  • Keep history work on keypresses and prevent stale selection events from overwriting restored text.

Type of Change

  • New feature

Testing

  • Focused composer, chat, persistence, and handoff tests.
  • Native browser fixture: rich-content resubmission, attachment opening, history traversal, queue priority, upload/draft protection, and chat reset. JSON report and screenshot saved locally.
  • Keyboard guard mutation checks: modifiers, composition, selections, and caret boundaries each fail when their guard is removed.
  • Root lint, type-check, all 60 audits, block-registry check, and full repository test suite.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 21, 2026 7:15pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

Comment thread ...space/[workspaceId]/home/components/user-input/components/prompt-editor/use-prompt-editor.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Adds Up/Down recall of sent messages in workspace and organization chat composers.

  • Chat composers let people browse sent messages with boundary arrows.

The previous resource-recall finding is fixed: saved resources now use the editor’s exact-token matcher, which preserves punctuation-wrapped mentions.

Reviews (3) · Last reviewed commit: "fix(chat): validate saved integration la..." · Reviewed by Greptile

@waleedlatif1

waleedlatif1 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

Comment thread ...space/[workspaceId]/home/components/user-input/components/prompt-editor/use-prompt-editor.ts
Comment thread ...space/[workspaceId]/home/components/user-input/components/prompt-editor/use-prompt-editor.ts
@waleedlatif1

waleedlatif1 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

Comment thread ...space/[workspaceId]/home/components/user-input/components/prompt-editor/use-prompt-editor.ts
@waleedlatif1
waleedlatif1 merged commit 04f524c into staging Oct 21, 2026
55 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/chat-composer-history branch October 21, 2026 19:29
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 21, 2026
Merged

This branch was previously deployed

1 inactive deployment
Preview — b5449f3e Deployed Oct 21, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1