Skip to content

[ci] Split sim processes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renanthera merged 2 commits into from
Jul 21, 2026
Merged

[ci] Split sim processes #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6e9820
[ci] Report which sim is being run. Split sims into separate processe…
renanthera Jul 20, 2026
301ef94
Merge branch 'main' into split-execute-script
renanthera Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions scripts/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ def generate_simc_input(profiles: list[Profile]):
deferred_options = []

def run_sim(binary: Path, profiles: list[str], prefix: list[str], suffix: list[str] = []):
proc = subprocess.Popen([binary] + prefix + profiles + suffix, stdout=sys.stdout, stderr=sys.stderr)
params = [binary, *prefix, *profiles, *suffix]
print(*params, sep=' ')
proc = subprocess.Popen(params, stdout=sys.stdout, stderr=sys.stderr)
proc.wait()
return proc.returncode

Expand All @@ -56,23 +58,26 @@ def print_dps_data(filename: Path):
return proc.returncode

def save_profiles(binary: Path, profiles: list[Profile], location: Path):
params = [
'single_actor_batch=1',
]
rc = []
for profile in profiles:
params += profile.params
params += [f'save={location}/{profile.expected_name()}.simc']
return run_sim(binary, params, ['output=/dev/null'])
print(f'Save Profile: {profile}')
rc.append(run_sim(binary, profile.params, ['output=/dev/null'], [f'save={location}/{profile.expected_name()}.simc']))
return rc

def run_profiles(binary: Path, profiles: list[Profile], location: Path):
rc = []
prefix = [
'single_actor_batch=1',
'output=/dev/null',
'target_error=0.05',
f'json={location}/output.json',
f'html={location}/output.html'
'output=/dev/null',
]
return run_sim(binary, [line for profile in profiles for line in profile.params], prefix)
for profile in profiles:
suffix = [
f'json={location}/output_{profile.expected_name()}.json',
f'html={location}/output_{profile.expected_name()}.html'
]
print(f'Run Profile: {profile}')
rc.append(run_sim(binary, profile.params, prefix, suffix))
return rc

parser = ArgumentParser(prog='SimulationCraft Profile Runner')
parser.add_argument('filenames', nargs='*', type=Profile)
Expand All @@ -89,11 +94,10 @@ def run_profiles(binary: Path, profiles: list[Profile], location: Path):

rc = []
if args.save:
rc.append(save_profiles(args.binary, args.filenames, args.save))
rc += save_profiles(args.binary, args.filenames, args.save)

if args.execute:
rc.append(run_profiles(args.binary, args.filenames, args.execute))
rc.append(print_dps_data(f'{args.execute}/output.json'))
rc += run_profiles(args.binary, args.filenames, args.execute)

print(rc)
exit(max(rc))