Skip to content

[Mage] Pyroclasm bugfix #11836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vituscze merged 2 commits into from
Sep 1, 2026
+5 −11
Merged

[Mage] Pyroclasm bugfix #11836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a91cfd
flamestrike pclasm fix
Lucasmingus Sep 1, 2026
5d82c56
adjust comment
Lucasmingus Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions engine/class_modules/sc_mage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,18 +2361,12 @@ struct hot_streak_spell_t : public custom_state_spell_t<fire_mage_spell_t, hot_s

c += p()->buffs.hyperthermia->check_value();

return c;
}

result_e calculate_result( action_state_t* s ) const override
{
result_e r = custom_state_spell_t::calculate_result( s );

// TODO: Pyroclasm 2pc is likely scripted. Fuel the Fire does not see the increased crit chance.
if ( r == RESULT_HIT && pyroclasm_active() && p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) )
r = RESULT_CRIT;
// The spelldata for Pyroclasm and the 12.1 2pc doesn't seem to be used,
// so we're hardcoding it here as they probably did serverside.
if ( pyroclasm_active() && p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) )
c += 1.0;

return r;
return c;
}

double composite_da_multiplier( const action_state_t* s ) const override
Expand Down
Loading