fix(update): flag MCP changes as escalations in the review diff - #112
Merged
Conversation
update and diff print a field-by-field manifest delta and mark escalations — permissions.network: no → YES and friends — but the delta covered no MCP fields at all. So the largest escalation a skill can make, adding a server that runs a new program with the agent's permissions, appeared in the review only as "skill.toml changed" in the file diff, with nothing distinguishing it from a typo fix. MCP is now reported server by server, with four escalations called out: - a new server — a new program running with your agent's permissions, which outranks any permission flag; - a server keeping its name while its command, args or url change: the rug-pull shape, where the thing you approved is not the thing that runs, and the one a human reviewer is least likely to catch; - a widened tool allowlist, including any narrowing to "*"; - a new env or header key, which is a new value handed to third-party code. Removing a server is a change, not an escalation, and an unchanged declaration produces no output. Adds 7 tests. 0.21.1.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
updateanddiffprint a manifest delta and mark escalations (permissions.network: no → YES). That delta covered no MCP fields at all — so the largest escalation a skill can make appeared in review only as "skill.toml changed" in the file diff, indistinguishable from a typo fix.Now
MCP is reported server by server, with four escalations called out:
*.Removing a server is a change, not an escalation. An unchanged declaration produces no output.
7 new tests; suite, typecheck, site
--checkand bench gate green. Ships as 0.21.1.