Skip to content

Fix Cadente SSL fallback for additional ListeningHosts#40

Merged
CypherPotato merged 1 commit into
mainfrom
codex/propose-fix-for-cadente-ssl-vulnerability
May 25, 2026
Merged

Fix Cadente SSL fallback for additional ListeningHosts#40
CypherPotato merged 1 commit into
mainfrom
codex/propose-fix-for-cadente-ssl-vulnerability

Conversation

@CypherPotato
Copy link
Copy Markdown
Member

Motivation

  • Restore the prior compatibility behavior where a builder-level UseSsl(...) call supplies SSL configuration for all configured hosts so that secondary ListeningHosts are not silently started as plaintext when they lack per-host SslOptions.

Description

  • In src/Http/Hosting/HttpServerHostContextBuilder.cs updated Build() to propagate the primary builder listeningHost.SslOptions to other entries in configuration.ListeningHosts when those entries have SslOptions == null using configuredHost.SslOptions ??= sslOptions.
  • The change preserves explicit per-host SSL configuration by only filling null SslOptions and does not alter behavior when hosts already define their own SSL options.

Testing

  • Ran the project build: dotnet build src/Sisk.Core.csproj -c Release --ignore-failed-sources, which completed successfully with only repository/SourceLink warnings and no build errors.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 024693a3e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Http/Hosting/HttpServerHostContextBuilder.cs
@CypherPotato CypherPotato merged commit 945981a into main May 25, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant