Fix Cadente chunked response framing with non-zero offsets#41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
count - offset) and could emit the terminal chunk on empty writes, which can corrupt HTTP/1.1 chunk framing and lead to response desynchronization.Description
cadente/Sisk.Cadente/Streams/HttpChunkedWriteStream.cssoWrite(byte[] buffer, int offset, int count)usescountfor the chunk-size header and treatscount == 0as a no-op, while leaving the terminal0\r\n\r\nemission inDisposeintact.Testing
dotnet test tests/Sisk.Core/tests.csproj --no-restorewhich completed successfully.dotnet testfrom the repo root was not applicable because there is no solution/project file at/workspace/core, producing an MSBUILD error.Codex Task